Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.10: set VERSION to 1.10.0-alpha1 #50420

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

DilumAluthge
Copy link
Member

Replaces #50394
Closes #50394

@DilumAluthge DilumAluthge added the release Release management and versioning. label Jul 5, 2023
@DilumAluthge
Copy link
Member Author

Okay, that worked. I guess Buildkite doesn't want to run on #50394 because #50394 was created before the julia-release-1.10 pipeline was created.

@DilumAluthge DilumAluthge marked this pull request as ready for review July 5, 2023 11:56
@Seelengrab
Copy link
Contributor

Seelengrab commented Jul 5, 2023

Just so you're aware, there's some discussion in #49805 about a potential issue with a previous PR feature-wise, that would be resolved with that PR (that just didn't seem to get merged before the feature freeze..)

@DilumAluthge
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.9", configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration=(buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@DilumAluthge
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs = ":release-1.9")

@KristofferC
Copy link
Member

This is just an alpha so it basically provides no guarantees.

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@KristofferC
Copy link
Member

KristofferC commented Jul 6, 2023

@DilumAluthge, what was the reason for rerunning nanosoldier? It's already running on the previous PR.

@KristofferC KristofferC merged commit f8ad15f into release-1.10 Jul 6, 2023
@KristofferC KristofferC deleted the dpa/1.10.0-alpha1 branch July 6, 2023 10:36
@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@DilumAluthge
Copy link
Member Author

Ah, I just assumed that when the old PR was closed, it would auto-cancel the Nanosoldier job. (Similar to how when you delete a branch, Buildkite auto-cancels the CI run on that branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants